feat: implement single component health status #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isometry
force-pushed
the
feature/single-component
branch
2 times, most recently
from
e651137 to
aab2609
Compare
isometry
commented
Apr 2, 2024
| @@ -111,6 +112,37 @@ func (s *PlatformHealthServer) Check(ctx context.Context, req *ph.HealthCheckReq | |||
|
|
|||
| providerServices := s.Config.GetInstances() | |||
|
|
|||
| componentPath := strings.Split(req.Component, "/") | |||
There was a problem hiding this comment.
/ as separate isn't ideal, as the kubernetes provider is using it within the constructed name of its instances.
isometry
force-pushed
the
feature/single-component
branch
from
aab2609 to
a18c770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.