Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use DefaultRegionChain if AWS_REGION is not specified #8

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: use DefaultRegionChain if AWS_REGION is not specified #8

merged 1 commit into from
Nov 16, 2023

Conversation

etolbakov
Copy link
Contributor

Description

Improve the way how AWS region is obtained by using the DefaultRegionChain if the AWS_REGION is not set

Related issue

#6

@etolbakov
Copy link
Contributor Author

@AlexsJones
Could you please take a look when you have time?

AlexsJones
AlexsJones approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for contributing

@AlexsJones AlexsJones merged commit 03093e1 into isotope-rs:main Nov 16, 2023
7 checks passed
@etolbakov etolbakov deleted the fix/determine-aws-region branch November 16, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etolbakov @AlexsJones