Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release_please action #9

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

etolbakov
Copy link
Contributor

Description

Add release-please-action in the release workflow

Related issue

#1

@etolbakov
Copy link
Contributor Author

@AlexsJones could you please take a look and share some feedback?
I was curious to try implementing this enhancement. I configured the release-please-action for one of my toy projects (the pipeline could be found here and made it work in the fist approximation.
Also noticed that release-please doesn't work with ncipollo/release-action@v1 (the latter complains about the "this release already exists"), that's why I had to replace it with a similar action softprops/action-gh-release@v1.
Anyway please let me know what do you think?

@AlexsJones
Copy link
Contributor

Thanks for the suggestion, I think we might find some compatibility challenges when using cargo publish as it wants to ensure the directory is as expected ( see the step that's failed ).

I am totally onboard with adding release please though as I love it - I might defer to @thschue to review this though as the expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants