Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json to Html converse #30

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Json to Html converse #30

merged 6 commits into from
Jul 4, 2024

Conversation

MatthewZMSU
Copy link
Contributor

Description

Sometimes scrapers use CustomJsAction to change state of a page but then they are not able to use Scrapy selectors even with html and cookies received from the service.
The implemented to_html method of PuppeteerJsonResponse solves the problem.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested it with several local spiders if everything worked fine. And implemented 1 more to check the implemented method

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Yatskov Yatskov merged commit 5b0ee56 into master Jul 4, 2024
14 checks passed
@Yatskov Yatskov deleted the json2html branch July 4, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants