-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MESH-5688: Tech-Debt: Increase coverage #369
Merged
adilfulara
merged 5 commits into
istio-ecosystem:master
from
adilfulara:MESH-0000-IncreaseCoverage
Jan 2, 2025
Merged
MESH-5688: Tech-Debt: Increase coverage #369
adilfulara
merged 5 commits into
istio-ecosystem:master
from
adilfulara:MESH-0000-IncreaseCoverage
Jan 2, 2025
+426
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 63.15% 71.40% +8.24%
==========================================
Files 91 77 -14
Lines 12153 10354 -1799
==========================================
- Hits 7675 7393 -282
+ Misses 4065 2570 -1495
+ Partials 413 391 -22 ☔ View full report in Codecov by Sentry. |
adilfulara
force-pushed
the
MESH-0000-IncreaseCoverage
branch
from
December 25, 2024 00:43
5739ff4
to
cee7363
Compare
- 100% coverage for clientdiscovery_handler Signed-off-by: Adil Fulara <[email protected]>
adilfulara
force-pushed
the
MESH-0000-IncreaseCoverage
branch
from
December 25, 2024 00:44
cee7363
to
a52f567
Compare
- Coverage for ShardController_Get Signed-off-by: Adil Fulara <[email protected]>
adilfulara
force-pushed
the
MESH-0000-IncreaseCoverage
branch
from
January 2, 2025 18:32
56a3bfe
to
640ebff
Compare
- Refine coverage task to ignore generate file test coverage Signed-off-by: Adil Fulara <[email protected]>
- Refine coverage task to ignore generate file test coverage Signed-off-by: Adil Fulara <[email protected]>
adilfulara
changed the title
Tech-Debt: Increase coverage
MESH-5688: Tech-Debt: Increase coverage
Jan 2, 2025
- Refine coverage task to ignore generate file test coverage Signed-off-by: Adil Fulara <[email protected]>
shriramsharma
approved these changes
Jan 2, 2025
aattuluri
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
adilfulara
added a commit
that referenced
this pull request
Jan 2, 2025
MESH-5688: Tech-Debt: Increase coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Thank you!