Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-5688: Tech-Debt: Increase coverage #369

Merged

Conversation

adilfulara
Copy link
Collaborator

@adilfulara adilfulara commented Dec 24, 2024

Description:

  • Increase overall coverage.

Thank you!

@adilfulara adilfulara marked this pull request as draft December 24, 2024 01:08
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (82738c6) to head (a1122b3).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   63.15%   71.40%   +8.24%     
==========================================
  Files          91       77      -14     
  Lines       12153    10354    -1799     
==========================================
- Hits         7675     7393     -282     
+ Misses       4065     2570    -1495     
+ Partials      413      391      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adilfulara adilfulara force-pushed the MESH-0000-IncreaseCoverage branch from 5739ff4 to cee7363 Compare December 25, 2024 00:43
- 100% coverage for clientdiscovery_handler

Signed-off-by: Adil Fulara <[email protected]>
@adilfulara adilfulara force-pushed the MESH-0000-IncreaseCoverage branch from cee7363 to a52f567 Compare December 25, 2024 00:44
- Coverage for ShardController_Get

Signed-off-by: Adil Fulara <[email protected]>
@adilfulara adilfulara force-pushed the MESH-0000-IncreaseCoverage branch from 56a3bfe to 640ebff Compare January 2, 2025 18:32
Adil Fulara added 2 commits January 2, 2025 11:27
- Refine coverage task to ignore generate file test coverage

Signed-off-by: Adil Fulara <[email protected]>
- Refine coverage task to ignore generate file test coverage

Signed-off-by: Adil Fulara <[email protected]>
@adilfulara adilfulara changed the title Tech-Debt: Increase coverage MESH-5688: Tech-Debt: Increase coverage Jan 2, 2025
- Refine coverage task to ignore generate file test coverage

Signed-off-by: Adil Fulara <[email protected]>
@adilfulara adilfulara marked this pull request as ready for review January 2, 2025 21:04
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adilfulara adilfulara merged commit b285613 into istio-ecosystem:master Jan 2, 2025
3 checks passed
adilfulara added a commit that referenced this pull request Jan 2, 2025
MESH-5688: Tech-Debt: Increase coverage
@adilfulara adilfulara deleted the MESH-0000-IncreaseCoverage branch January 2, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants