Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent way to install using the Makefile #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Consistent way to install using the Makefile #12

wants to merge 2 commits into from

Conversation

nacx
Copy link
Contributor

@nacx nacx commented Oct 18, 2018

No description provided.

@nacx nacx mentioned this pull request Oct 18, 2018
Open
@ZackButcher
Copy link
Contributor

No, the correct way to install coddiwomple go get github.com/istio-ecosystem/coddiwomple/cmd/cw and we should update the README to say that. go get downloads the sources and builds the, putting the binary into $GOPATH/bin (which should be in your $PATH). go install only works if the files exist locally.

@ZackButcher
Copy link
Contributor

For the record I can't go get coddiwomple atm. Tempted to move it up to go 1.11 but the dependencies on the operator SDK might be a PITA.

@mt-inside
Copy link
Contributor

@nacx : Zack and I plan to move cw to go1.11 soon, should remove godep problems. Do you want to change this diff to be ago get (and would you mind fixing README too?), and then we'll merge that and consider the broken go get to be a separate, high-priority bug.

@nacx nacx force-pushed the nacx/install branch 2 times, most recently from 212c596 to d5fa396 Compare October 23, 2018 15:34
mt-inside
mt-inside approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@mt-inside mt-inside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt-inside mt-inside mt-inside approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nacx @ZackButcher @mt-inside