Improve failure messages for supportedversion unit tests #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgn
force-pushed
the
improve-failure-msgs
branch
from
c3fdd81 to
bc4b0d8
Compare
luksa
reviewed
Oct 21, 2024
luksa
approved these changes
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 57.44% 57.44%
=======================================
Files 35 35
Lines 2061 2061
=======================================
Hits 1184 1184
Misses 825 825
Partials 52 52 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Grimm <[email protected]>
dgn
force-pushed
the
improve-failure-msgs
branch
from
a67956f to
7a95d05
Compare
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 21, 2024
* upstream/main: Include integration tests in code coverage calculation (istio-ecosystem#427) Improve failure messages for supportedversion unit tests (istio-ecosystem#442)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 21, 2024
* upstream/main: Add spec.values.global.platform to IstioCNI (istio-ecosystem#443) Include integration tests in code coverage calculation (istio-ecosystem#427) Improve failure messages for supportedversion unit tests (istio-ecosystem#442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.