Ignore istio version suffix used in the downstream builds #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is expecting to see the same version parsed from versions.yaml and a version string returned by `pilot-discovery version`. This is not the same in downstream builds as we use the `_ossm` suffix. Signed-off-by: Filip Brychta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 75.93% 75.73% -0.20%
==========================================
Files 35 35
Lines 2061 2061
==========================================
- Hits 1565 1561 -4
- Misses 425 428 +3
- Partials 71 72 +1 ☔ View full report in Codecov by Sentry. |
pbajjuri20
approved these changes
Oct 23, 2024
dgn
approved these changes
Oct 25, 2024
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 25, 2024
* upstream/main: Ignore istio version suffix used in the downstream builds (istio-ecosystem#446) Pin the version of OLM we use for e2e tests (istio-ecosystem#450)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 25, 2024
* upstream/main: Ignore istio version suffix used in the downstream builds (istio-ecosystem#446) Pin the version of OLM we use for e2e tests (istio-ecosystem#450)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The test is expecting to see the same version parsed from versions.yaml and a version string returned by
pilot-discovery version. This is not the same in downstream builds as we use the_ossmsuffix.