Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly-images workflow #447

Merged

Conversation

bmangoen
Copy link
Contributor

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Moves the nightly image builds into a GitHub Action

Which issue(s) this PR fixes:

Fixes #84

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (06bb204) to head (0f5aa27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   75.93%   75.93%           
=======================================
  Files          35       35           
  Lines        2061     2061           
=======================================
  Hits         1565     1565           
  Misses        425      425           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmangoen
Copy link
Contributor Author

/retest

@FilipB
Copy link
Collaborator

FilipB commented Oct 24, 2024

I guess we should prepare a PR which is removing the job running in our fork before merging this.

@bmangoen
Copy link
Contributor Author

I guess we should prepare a PR which is removing the job running in our fork before merging this.

@FilipB Yes the followiung PR is waiting for review as well

@istio-testing istio-testing merged commit b56c95d into istio-ecosystem:main Oct 24, 2024
17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 24, 2024
* upstream/main:
  Add nightly-images workflow (istio-ecosystem#447)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 24, 2024
* upstream/main:
  Add nightly-images workflow (istio-ecosystem#447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move nightly build job to istio-ecosystem repo
3 participants