Rework Multi-Primary documentation #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I split some tasks up as they were doing more than one thing and I inlined some of the certificate generation so users wouldn't need to curl a Makefile. Signed-off-by: Daniel Grimm <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 75.93% 75.54% -0.40%
==========================================
Files 35 35
Lines 2061 2073 +12
==========================================
+ Hits 1565 1566 +1
- Misses 425 433 +8
- Partials 71 74 +3 ☔ View full report in Codecov by Sentry. |
fjglira
approved these changes
Oct 31, 2024
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 31, 2024
* upstream/main: Rework Multi-Primary documentation (istio-ecosystem#456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split some tasks up as they were doing more than one thing and I inlined some of the certificate generation so users wouldn't need to curl a Makefile.