Add config option to set maximum Istio version

[dgn]

No description provided.

[dgn]

It looks like the pre-release versions are not accepted by the semver regex. Which is strange, I think they should be fine

nevermind this is about latest

[luksa]

Hmm, this approach won't work, because spec.version is currently not really an actual version number. It's just a string (for example, when spec.version: latest, latest is just the name, whereas the actual version number is whatever is set in the version field in versions.yaml). But the operator currently doesn't even read the versions.yaml file.

The operator currently doesn't really know anything about versions. It simply takes the spec.version string and uses it to construct the path for the chart it must render.

We either need to remove the version names from versions.yaml and just use the version number as the version name (but this prevents us from using "latest" as the version name), or we make the operator read the versions.yaml file, allowing it to map the version name to the version number.

[luksa]

Can you add the version to the error message. This makes it read as though setting the field itself is not supported.

[dgn]

done!

[luksa]

Actually, we could get rid of the version names by simply defaulting an empty spec.version to whatever the latest version is. Although, without versions.yaml, the operator would have to read the directory names and find the highest semver, which is obviously not the best approach. So, we definitely need to pass the versions.yaml file to the operator, so we don't really need to get rid of the version names.

[dgn]

Hmm, this approach won't work, because spec.version is currently not really an actual version number. It's just a string (for example, when spec.version: latest, latest is just the name, whereas the actual version number is whatever is set in the version field in versions.yaml). But the operator currently doesn't even read the versions.yaml file.

The operator currently doesn't really know anything about versions. It simply takes the spec.version string and uses it to construct the path for the chart it must render.

We either need to remove the version names from versions.yaml and just use the version number as the version name (but this prevents us from using "latest" as the version name), or we make the operator read the versions.yaml file, allowing it to map the version name to the version number.

I think this is good and we should do it as part of implementing version aliases. latest then just becomes an alias for the latest version in versions.yaml.

For this specific instance, we just need to be able have an upper limit on the version, so IMO it would be a bit overkill to implement this (and then revise it anyway when implementing version aliases).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (5af33d3) to head (10ab74e).
Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   78.21%   78.50%   +0.29%     
==========================================
  Files          38       38              
  Lines        2272     2294      +22     
==========================================
+ Hits         1777     1801      +24     
+ Misses        404      403       -1     
+ Partials       91       90       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dgn]

Closing this as per our discussion. We'll use a normal branching strategy and re-evaluate after a few minor releases