Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure profile files are included in the revisiontags chart #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Dec 18, 2024

No description provided.

@luksa luksa requested a review from a team as a code owner December 18, 2024 11:51
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (977c9fb) to head (92d6209).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   75.76%   75.72%   -0.05%     
==========================================
  Files          39       39              
  Lines        2476     2476              
==========================================
- Hits         1876     1875       -1     
- Misses        510      511       +1     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is exactly the fix I had in mind. Only thing missing for me would be a test that verifies it (e.g. by altering an integration test to use a profile).

@luksa
Copy link
Contributor Author

luksa commented Dec 18, 2024

I think an e2e would be better. It doesn't look like we have an e2e test for revision tags yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants