Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup gcsweb and velodrome ing object configs: part 2 #2525

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Cleanup gcsweb and velodrome ing object configs: part 2 #2525

merged 1 commit into from
Mar 26, 2020

Conversation

clarketm
Copy link
Member

@clarketm clarketm commented Mar 19, 2020 •
edited
Loading

pre: #2524

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 19, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2020
@clarketm clarketm added the do-not-merge/hold Block automatic merging of a PR. label Mar 19, 2020
@clarketm clarketm mentioned this pull request Mar 19, 2020
Merged
5 tasks
@clarketm clarketm force-pushed the resource-cleanup-2 branch from d8e8b4c to 3708a47 Compare March 19, 2020 00:59
fejta
fejta approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/assign @chases2

@clarketm clarketm force-pushed the resource-cleanup-2 branch from 3708a47 to 1b3513f Compare March 25, 2020 06:48
This was referenced Mar 25, 2020
Merged
Merged
@clarketm
Copy link
Member Author

clarketm commented Mar 25, 2020 •
edited
Loading

Hold off on this for now. The previous deploy failed. https://prow.istio.io/view/gcs/istio-prow/logs/deploy-prow_test-infra_postsubmit/47. Either the kubectl version needs to be updated in the image or the prune command needs to be modified.

prerequisite:

@clarketm clarketm mentioned this pull request Mar 25, 2020
Merged
@clarketm clarketm force-pushed the resource-cleanup-2 branch from 1b3513f to 18dab7f Compare March 26, 2020 07:06
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2020
@clarketm
Copy link
Member Author

Updated this to delete the 2 temporary ingress objects now that the permanent ones are active.

@clarketm clarketm removed the do-not-merge/hold Block automatic merging of a PR. label Mar 26, 2020
@clarketm
Copy link
Member Author

DNS A records updated. This is safe to merge.

@istio-testing istio-testing merged commit 1e3bcce into istio:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@chases2 chases2 Awaiting requested review from chases2

@cjwagner cjwagner Awaiting requested review from cjwagner

@Katharine Katharine Awaiting requested review from Katharine

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clarketm @fejta @michelle192837 @chases2 @googlebot @istio-testing