python: use custom handler for validation error #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoto7250
changed the title
zhanpon
reviewed
Dec 4, 2024
webapp/python/app/main.py
Outdated
| @@ -28,12 +29,21 @@ class PostInitializeResponse(BaseModel): | |||
|
|
|||
|
|
|||
| @app.exception_handler(HTTPStatus.INTERNAL_SERVER_ERROR) | |||
There was a problem hiding this comment.
ここだけstatus codeを渡しているのが見づらい気がしたので、かわりにExceptionを渡すようにしたほうがいいと思います
There was a problem hiding this comment.
Exception 全てを受けるのですが、調査したところ簡単に出来なさそうでした。
拾えれば拾おうと思っていたのですが、他言語でも基本的にフレームワーク依存だと思いましたので、
この対応は無しで進めれればと考えています
There was a problem hiding this comment.
なるほど、すべて拾うようなexception handlerは作れないんですね。了解です！
kyoto7250
force-pushed
the
python_custom_handler_for_validator
branch
from
dee45ca to
33042df
Compare
kyoto7250
changed the title
kyoto7250
commented
Dec 5, 2024
| @app.exception_handler(HTTPStatus.INTERNAL_SERVER_ERROR) | ||
| def internal_exception_handler(_request: Request, exc: Exception) -> JSONResponse: | ||
| @app.exception_handler(SQLAlchemyError) | ||
| def sql_alchemy_error_handler(_: Request, exc: SQLAlchemyError) -> JSONResponse: |
There was a problem hiding this comment.
SQLAlchemyErrorがパッケージのExceptionの基底で、__str__ が定義されているので str(exc) で問題ない
| ) -> JSONResponse: | ||
| return JSONResponse( | ||
| status_code=HTTPStatus.METHOD_NOT_ALLOWED, | ||
| content={"message": str(exc.errors())}, |
There was a problem hiding this comment.
exc.errors() で中身が見れる
https://fastapi.tiangolo.com/ja/tutorial/handling-errors/#requestvalidationerror
zhanpon
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #471
バリデーションを {"message": } の形式で返却する