python: raise if row is None in get_latest_ride_status #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoto7250
force-pushed
the
raise_get_latest_ride_stauts
branch
from
aefb4b1 to
ed7d9a1
Compare
kyoto7250
changed the title
zhanpon
reviewed
Dec 4, 2024
kyoto7250
force-pushed
the
raise_get_latest_ride_stauts
branch
from
3b0780c to
eda7f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statusが存在しない場合には HTTPException を raise させます。Go実装でも常に raise していること、 ride に対応する ride_status が存在しないことはドメインから考えても異常系である（ride 挿入時に常に ride_status は挿入されているはず）ので、本対応で問題ないと考えています