Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai-integration fix embedded kafka for spring 3.2.4 #1815

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Jul 2, 2024

Description

Fix openai-integration embedded kafka test with spring 2.3.4

Reference

#1536

Check-List

  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date

@simonhir simonhir self-assigned this Jul 2, 2024
@github-actions github-actions bot added digiwf-integrations bug Something isn't working labels Jul 2, 2024
@simonhir simonhir marked this pull request as ready for review July 2, 2024 08:37
@simonhir simonhir enabled auto-merge (squash) July 2, 2024 08:37
Copy link
Contributor

@markostreich markostreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.69%. Comparing base (b630b2f) to head (8bb9624).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1815   +/-   ##
=========================================
  Coverage     44.68%   44.69%           
  Complexity     1714     1714           
=========================================
  Files           659      659           
  Lines          9645     9644    -1     
  Branches        484      484           
=========================================
  Hits           4310     4310           
+ Misses         5148     5147    -1     
  Partials        187      187           
Flag Coverage Δ
unittests 44.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir merged commit 03e10ec into dev Jul 2, 2024
19 checks passed
@simonhir simonhir deleted the bug/openai-integration-fix-spring-3.2.4-bump branch July 2, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants