🔧 rm default Expires response header filter (#303)

* 🔧 rm default Expires response header remove * 🔥 rm expires header checks from tests
it-at-m · Dec 5, 2024 · 74acd8c · 74acd8c
1 parent 0e6047c
commit 74acd8c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 16 deletions.
diff --git a/refarch-gateway/src/main/resources/application.yml b/refarch-gateway/src/main/resources/application.yml
@@ -19,7 +19,6 @@ spring:
             allowedHeaders: "*"
             allowCredentials: true
       default-filters:
-        - RemoveResponseHeader=Expires
         - RemoveRequestHeader=cookie
         - RemoveRequestHeader=x-xsrf-token
         - TokenRelay=

diff --git a/...src/test/java/de/muenchen/refarch/gateway/filter/GlobalAuthenticationErrorFilterTest.java b/...src/test/java/de/muenchen/refarch/gateway/filter/GlobalAuthenticationErrorFilterTest.java
@@ -37,8 +37,7 @@ void setup() {
                         .withStatus(HttpStatus.UNAUTHORIZED.value())
                         .withHeaders(new HttpHeaders(
                                 new HttpHeader("Content-Type", "application/json"),
-                                new HttpHeader("WWW-Authenticate", "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\""),
-                                new HttpHeader("Expires", "Wed, 21 Oct 2099 07:28:06 GMT")))
+                                new HttpHeader("WWW-Authenticate", "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\"")))
                         .withBody("{ \"testkey\" : \"testvalue\" }")));
     }
 
@@ -49,7 +48,6 @@ void backendAuthenticationError() {
                 .expectStatus().isEqualTo(HttpStatus.UNAUTHORIZED)
                 .expectHeader().valueMatches("Content-Type", "application/json")
                 .expectHeader().doesNotExist("WWW-Authenticate")
-                .expectHeader().valueMatches("Expires", "0")
                 .expectBody()
                 .jsonPath("$.status").isEqualTo("401")
                 .jsonPath("$.error").isEqualTo("Authentication Error");

diff --git a/...way/src/test/java/de/muenchen/refarch/gateway/filter/GlobalBackend5xxTo400MapperTest.java b/...way/src/test/java/de/muenchen/refarch/gateway/filter/GlobalBackend5xxTo400MapperTest.java
@@ -45,15 +45,13 @@ void backendError500() {
                         .withHeaders(new HttpHeaders(
                                 new HttpHeader(org.springframework.http.HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.getMimeType()),
                                 new HttpHeader(org.springframework.http.HttpHeaders.WWW_AUTHENTICATE,
-                                        "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\""),
-                                new HttpHeader(org.springframework.http.HttpHeaders.EXPIRES, "Wed, 21 Oct 2099 07:28:06 GMT")))
+                                        "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\"")))
                         .withBody("{ \"testkey\" : \"testvalue\" }")));
 
         webTestClient.get().uri("/api/refarch-gateway-backend-service/remote").exchange()
                 .expectStatus().isEqualTo(HttpStatus.BAD_REQUEST)
                 .expectHeader().valueMatches(org.springframework.http.HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.getMimeType())
                 .expectHeader().doesNotExist(org.springframework.http.HttpHeaders.WWW_AUTHENTICATE)
-                .expectHeader().valueMatches(org.springframework.http.HttpHeaders.EXPIRES, "0")
                 .expectBody()
                 .jsonPath("$.status").isEqualTo("400")
                 .jsonPath("$.error").isEqualTo("Bad Request");
@@ -69,15 +67,13 @@ void backendError200() {
                         .withHeaders(new HttpHeaders(
                                 new HttpHeader(org.springframework.http.HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.getMimeType()),
                                 new HttpHeader(org.springframework.http.HttpHeaders.WWW_AUTHENTICATE,
-                                        "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\""),
-                                new HttpHeader(org.springframework.http.HttpHeaders.EXPIRES, "Wed, 21 Oct 2099 07:28:06 GMT")))
+                                        "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\"")))
                         .withBody("{ \"testkey\" : \"testvalue\" }")));
 
         webTestClient.get().uri("/api/refarch-gateway-backend-service/remote").exchange()
                 .expectStatus().isEqualTo(HttpStatus.OK)
                 .expectHeader().valueMatches(org.springframework.http.HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.getMimeType())
                 .expectHeader().doesNotExist(org.springframework.http.HttpHeaders.WWW_AUTHENTICATE)
-                .expectHeader().valueMatches(org.springframework.http.HttpHeaders.EXPIRES, "0")
                 .expectBody()
                 .jsonPath("$.testkey").isEqualTo("testvalue");
     }

diff --git a/...ateway/src/test/java/de/muenchen/refarch/gateway/filter/GlobalBackendErrorFilterTest.java b/...ateway/src/test/java/de/muenchen/refarch/gateway/filter/GlobalBackendErrorFilterTest.java
@@ -43,8 +43,7 @@ void setup() {
                         .withStatus(HttpStatus.INTERNAL_SERVER_ERROR.value())
                         .withHeaders(new HttpHeaders(
                                 new HttpHeader("Content-Type", "application/json"),
-                                new HttpHeader("WWW-Authenticate", "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\""),
-                                new HttpHeader("Expires", "Wed, 21 Oct 2099 07:28:06 GMT")))
+                                new HttpHeader("WWW-Authenticate", "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\"")))
                         .withBody("{ \"testkey\" : \"testvalue\" }")));
     }
 
@@ -55,7 +54,6 @@ void backendError() {
                 .expectStatus().isEqualTo(HttpStatus.INTERNAL_SERVER_ERROR)
                 .expectHeader().valueMatches("Content-Type", "application/json")
                 .expectHeader().doesNotExist("WWW-Authenticate")
-                .expectHeader().valueMatches("Expires", "0")
                 .expectBody()
                 .jsonPath("$.status").isEqualTo("500")
                 .jsonPath("$.error").isEqualTo("Internal Server Error");

diff --git a/refarch-gateway/src/test/java/de/muenchen/refarch/gateway/route/BackendRouteTest.java b/refarch-gateway/src/test/java/de/muenchen/refarch/gateway/route/BackendRouteTest.java
@@ -40,8 +40,7 @@ void setup() {
                         .withHeaders(new HttpHeaders(
                                 new HttpHeader(org.springframework.http.HttpHeaders.CONTENT_TYPE, "application/json"),
                                 new HttpHeader(org.springframework.http.HttpHeaders.WWW_AUTHENTICATE,
-                                        "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\""), // removed by route filter
-                                new HttpHeader(org.springframework.http.HttpHeaders.EXPIRES, "Wed, 21 Oct 2099 07:28:06 GMT") // removed by route filter
+                                        "Bearer realm=\"Access to the staging site\", charset=\"UTF-8\"") // removed by route filter
                         ))
                         .withBody("{ \"testkey\" : \"testvalue\" }")));
     }
@@ -58,7 +57,6 @@ void backendRouteResponse() {
                 .expectStatus().isEqualTo(HttpStatus.OK)
                 .expectHeader().valueMatches(org.springframework.http.HttpHeaders.CONTENT_TYPE, "application/json")
                 .expectHeader().doesNotExist(org.springframework.http.HttpHeaders.WWW_AUTHENTICATE)
-                .expectHeader().valueMatches(org.springframework.http.HttpHeaders.EXPIRES, "0")
                 .expectBody().jsonPath("$.testkey").isEqualTo("testvalue");
 
         verify(getRequestedFor(urlEqualTo("/remote/endpoint"))