-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maint/use central ci actions #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes still needed (adjust parameter require, change comments to english
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please wait this is finished it-at-m/refarch-templates#513
@devtobi here you see that a wrapper for actions doesn't make sense. If a person a little bit change a release, he/she can't use the wrapper. I think our templates shoud be more flexible |
In my opinion then it is a lack of features inside the custom written wrapper. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes from it-at-m/refarch-templates#513 will be adopted in a separate pr |
Changes are adopted in a separate pr
@coderabbitai full review |
Caution Review failedThe pull request is closed. WalkthroughThe changes involve the removal of several GitHub Actions workflows and actions, specifically the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Maven Build
participant Docker Build
User->>GitHub Actions: Trigger Workflow
GitHub Actions->>Maven Build: Execute Maven Build
Maven Build->>GitHub Actions: Return Artifact Name
GitHub Actions->>Docker Build: Build and Push Image
Docker Build->>GitHub Actions: Image Built Successfully
GitHub Actions->>User: Workflow Complete
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Use central templates and actions from .github
Summary by CodeRabbit
Release Notes
New Features
Changes
Bug Fixes