Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint/use central ci actions #285

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Maint/use central ci actions #285

merged 10 commits into from
Nov 28, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Nov 26, 2024

Description

Use central templates and actions from .github

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new workflow for building multiple modules, enhancing CI/CD capabilities.
  • Changes

    • Removed several workflows, streamlining the build process.
    • Updated existing workflows to utilize remote actions for building images.
    • Adjusted input parameters for Maven release actions to improve clarity and requirements.
  • Bug Fixes

    • Fixed execution flow issues by removing unnecessary conditional checks.

@simonhir simonhir self-assigned this Nov 26, 2024
@github-actions github-actions bot added the Type: Maintenance The issue contains maintenance work. label Nov 26, 2024
@simonhir simonhir marked this pull request as ready for review November 26, 2024 09:05
@simonhir simonhir requested a review from a team as a code owner November 26, 2024 09:05
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/actions/release-maven/action.yaml Outdated Show resolved Hide resolved
.github/actions/release-maven/action.yaml Show resolved Hide resolved
.github/workflows/maven_node_build.yaml Outdated Show resolved Hide resolved
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes still needed (adjust parameter require, change comments to english

Copy link
Contributor

@hupling hupling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait this is finished it-at-m/refarch-templates#513

@hupling
Copy link
Contributor

hupling commented Nov 28, 2024

@devtobi here you see that a wrapper for actions doesn't make sense. If a person a little bit change a release, he/she can't use the wrapper. I think our templates shoud be more flexible

@devtobi
Copy link
Member

devtobi commented Nov 28, 2024

@devtobi here you see that a wrapper for actions doesn't make sense. If a person a little bit change a release, he/she can't use the wrapper. I think our templates shoud be more flexible

In my opinion then it is a lack of features inside the custom written wrapper. ;)

Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir
Copy link
Member Author

Changes from it-at-m/refarch-templates#513 will be adopted in a separate pr

@simonhir simonhir dismissed hupling’s stale review November 28, 2024 11:21

Changes are adopted in a separate pr

@simonhir simonhir merged commit b37b478 into main Nov 28, 2024
11 checks passed
@simonhir simonhir deleted the maint/use-central-ci-actions branch November 28, 2024 11:21
@simonhir simonhir mentioned this pull request Nov 28, 2024
@simonhir
Copy link
Member Author

@coderabbitai full review

Copy link

coderabbitai bot commented Nov 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve the removal of several GitHub Actions workflows and actions, specifically the build-image action and workflows like build-gateway, build-tools, and modifications to release workflows. The release input parameter has been eliminated in multiple workflows, and several input parameters have been updated to be required. A new workflow, maven_node_build.yaml, has been introduced to automate the build process for multiple modules with conditional execution based on the presence of specific files.

Changes

File Path Change Summary
.github/actions/build-image/action.yaml Action removed.
.github/actions/release-maven/action.yaml Input parameter release removed; several inputs updated to required.
.github/workflows/build_gateway.yaml Workflow removed.
.github/workflows/build_integrations.yaml Output variable ARTIFACT_NAME added; actions updated to use remote actions; input parameter module changed to app-path.
.github/workflows/build_tools.yaml Workflow removed.
.github/workflows/maven_node_build.yaml New workflow added to automate builds for multiple modules with conditional execution.
.github/workflows/release.yaml Input parameter release removed; actions updated to use remote actions; job execution conditions modified.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHub Actions
    participant Maven Build
    participant Docker Build

    User->>GitHub Actions: Trigger Workflow
    GitHub Actions->>Maven Build: Execute Maven Build
    Maven Build->>GitHub Actions: Return Artifact Name
    GitHub Actions->>Docker Build: Build and Push Image
    Docker Build->>GitHub Actions: Image Built Successfully
    GitHub Actions->>User: Workflow Complete
Loading

🐰 "In the land of code, where actions play,
A new workflow hops in, brightening the day!
Old paths are cleared, and new ones arise,
With builds and pushes, we reach for the skies!
So let’s celebrate changes, both big and small,
For in this coding garden, we flourish for all!" 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance The issue contains maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants