Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 remove logout functionality #31

Merged
merged 2 commits into from
Jul 30, 2024
Merged

🔥 remove logout functionality #31

merged 2 commits into from
Jul 30, 2024

Conversation

simonhir
Copy link
Member

Description

Remove logout functionality as currently doesn't really work with oAuth.

Reference

Issues closes #24

@simonhir simonhir self-assigned this Jul 26, 2024
@simonhir simonhir changed the title 🔥 #24 remove logout functionality 🔥 remove logout functionality Jul 26, 2024
@simonhir simonhir requested a review from devtobi July 26, 2024 09:51
devtobi
devtobi approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but did not test locally.

@simonhir simonhir requested review from a team as code owners July 30, 2024 06:42
@simonhir
Copy link
Member Author

simonhir commented Jul 30, 2024 •
edited
Loading

but did not test locally.

Don't know what i thought, but i didn't test it either 🤦‍♂️.
Fixed it now and when accessing /logout it is handled by the frontend route, as every other non existing endpoint.

@simonhir simonhir requested a review from devtobi July 30, 2024 06:44
devtobi
devtobi approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit ac60509 into main Jul 30, 2024
5 checks passed
@simonhir simonhir deleted the refactor/rm-logout branch July 30, 2024 11:22
@devtobi devtobi added Component: API-Gateway Issues regarding the API Gateway Type: Maintenance The issue contains maintenance work. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtobi devtobi devtobi approved these changes

Assignees

@simonhir simonhir

Labels
Component: API-Gateway Issues regarding the API Gateway Type: Maintenance The issue contains maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove logout endpoint
2 participants
@simonhir @devtobi