Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 security allow actuator probes #35

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Jul 29, 2024

Description

Permit actuator probe endpoints for deployment health checks.

Required for #23

Closes #37

@simonhir simonhir self-assigned this Jul 29, 2024
@simonhir simonhir requested review from a team as code owners July 29, 2024 09:34
@simonhir simonhir force-pushed the bug/security-allow-actuator-probes branch from 40f39e5 to 6957c56 Compare July 29, 2024 09:35
@DanielOber
Copy link
Contributor

DanielOber commented Jul 29, 2024

LGTM and works locally. But can you write tests for it like we did here

Copy link
Contributor

@DanielOber DanielOber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit 0a085dd into main Jul 30, 2024
5 checks passed
@simonhir simonhir deleted the bug/security-allow-actuator-probes branch July 30, 2024 09:42
@simonhir simonhir added the bug label Jul 31, 2024
@devtobi devtobi added Component: API-Gateway Issues regarding the API Gateway Type: Bug The issue is a bug labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: API-Gateway Issues regarding the API Gateway Type: Bug The issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test security configuration
3 participants