Merge pull request #110 from open-source-contributions/test_improvement

Test improvement

.gitattributes

@@ -1,4 +1,5 @@
 /example export-ignore
 /tests export-ignore
+/phpunit.xml export-ignore
 .gitattributes export-ignore
 .gitattributes merge=ours

.travis.yml

@@ -1,19 +1,19 @@
 language: php
 
 php:
-  - 7.2.26
-  - 7.3.12
-  - 7.4.1
+  - 7.2.28
+  - 7.3.15
+  - 7.4.3
 
 cache:
   directories:
     - $HOME/.composer/cache
-    
+
 install:
   - composer install --no-interaction
   - mkdir -p example/idp_metadata
   - php bin/download_idp_metadata.php ./example/idp_metadata
-  
+
 script:
   - find . | grep 'php$' | grep -v vendor | grep -v tests | xargs ./vendor/bin/phpcs --standard=PSR2
   - vendor/bin/phpunit --stderr tests

phpunit.xml

@@ -0,0 +1,18 @@
+<phpunit
+	bootstrap="vendor/autoload.php"
+	convertErrorsToExceptions="true"
+	convertNoticesToExceptions="true"
+	convertWarningsToExceptions="true"
+	strict="true">
+
+	<testsuite name="spid-php-lib tests">
+		<directory>./tests</directory>
+	</testsuite>
+
+	<filter>
+		<whitelist>
+			<directory suffix=".php">src</directory>
+		</whitelist>
+	</filter>
+
+</phpunit>

tests/IdpTest.php

@@ -1,8 +1,6 @@
 <?php
 declare(strict_types=1);
 
-require_once(__DIR__ . "/../vendor/autoload.php");
-
 final class IdpTest extends PHPUnit\Framework\TestCase
 {
     private static $settings = [
@@ -22,7 +20,7 @@ final class IdpTest extends PHPUnit\Framework\TestCase
             ["name", "familyName", "fiscalNumber", "email", "spidCode"]
             ]
         ];
-    
+
     private static $idps = [];
 
     public static function setupIdps()
@@ -86,11 +84,11 @@ public function testLoadXMLWIthWrongFilePath()
         $sp->settings['idp_metadata_folder'] = '/wrong/path/to/metadata/';
 
         $this->expectException(\Exception::class);
-        $loaded = $idp->loadFromXml(self::$idps[0]);
-        
+        $idp->loadFromXml(self::$idps[0]);
+
         $this->assertAttributeNotEmpty(null, $idp);
         $this->assertAttributeNotEmpty(null, $idp);
     }
 
     // TODO check if logout response should redirect
-}
+}