Make the build more robust against non-standard installations of some dependencies #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use pkg-config to find expat during configure * Adjust the Makefile.am's
And use <random>.
No need to use ptr_fun anymore.
They should come with <netdb.h> if the appropriate feature test macros are defined. But defining the right ones (e.g. _POSIX_C_SOURCE with value 200112L or even 200809L), ideally in configure.ac, requires more investigation, given that different macros are spread around the codebase. This change is aimed at quickly fixing the build on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular voms now should build when dependencies such as openssl, expat and gsoap come with brew. This setup is somewhat similar to when the build is on macOS and is instrumental to fix #137.
Closes #137