Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive chmod/chown to remote_directory resource. #218

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add recursive chmod/chown to remote_directory resource. #218

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa1bc01
Add recursive chmod/chown to remote_directory resource.
Jul 10, 2016
a66d069
* Change class to Symbol to TrueClass/FalseClass
yamajun Dec 26, 2016
0f2fb31
Too much long name. But clearly name about target.
yamajun Dec 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/itamae/resource/remote_directory.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ class RemoteDirectory < Base
define_attribute :mode, type: String
define_attribute :owner, type: String
define_attribute :group, type: String
define_attribute :recursive_mode, type: [String, Symbol], default: :true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting false as the default value is better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better way of recursive chown/chmod in default in my local usage.
But, this patch changes behavior from current version. It is not good.

I change to boolean false in default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just change to default on false.
Sorry too late.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use true instead of symbol :true?

define_attribute :recursive_owner, type: [String, Symbol], default: :true

def pre_action
directory = ::File.expand_path(attributes.source, ::File.dirname(@recipe.path))
Expand Down Expand Up @@ -56,10 +58,18 @@ def show_differences

def action_create(options)
if attributes.mode
run_specinfra(:change_file_mode, @temppath, attributes.mode)
if attributes.recursive_mode == :true
run_specinfra(:change_file_mode, @temppath, attributes.mode, :recursive => true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If attributes.recursive_mode is boolean, you can simply write this run_specinfra(:change_file_mode, @temppath, attributes.mode, recursive: attributes.recursive_mode)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to your suggestion!
Replace to your code and testing now.

else
run_specinfra(:change_file_mode, @temppath, attributes.mode)
end
end
if attributes.owner || attributes.group
run_specinfra(:change_file_owner, @temppath, attributes.owner, attributes.group)
if attributes.recursive_owner == :true
run_specinfra(:change_file_owner, @temppath, attributes.owner, attributes.group, :recursive => true)
else
run_specinfra(:change_file_owner, @temppath, attributes.owner, attributes.group)
end
end

if run_specinfra(:check_file_is_file, attributes.path)
Expand Down