Added comments to ignore remaining warnings

ite-klass · Oct 17, 2017 · f41eaf1 · f41eaf1
1 parent abd9562
commit f41eaf1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs
@@ -247,6 +247,7 @@ bool TryConvertValueTuple(object value, Destructuring destructuring, Type valueT
                 definition == typeof(ValueTuple<,,,,>) || definition == typeof(ValueTuple<,,,,,>) ||
                 definition == typeof(ValueTuple<,,,,,,>))
 #else
+            // ReSharper disable once PossibleNullReferenceException
             var defn = definition.FullName;
             if (defn == "System.ValueTuple`1" || defn == "System.ValueTuple`2" ||
                 defn == "System.ValueTuple`3" || defn == "System.ValueTuple`4" ||

diff --git a/src/Serilog/Context/LogContext.cs b/src/Serilog/Context/LogContext.cs
@@ -254,6 +254,8 @@ public DisposableObjectHandle(object o) : base(o)
             public override object InitializeLifetimeService()
             {
                 var lease = (ILease)base.InitializeLifetimeService();
+                // ReSharper disable once PossibleNullReferenceException
+                // not 100% sure this will never occur ...
                 lease.Register(LifeTimeSponsor);
                 return lease;
             }

diff --git a/src/Serilog/Core/Pipeline/MessageTemplateCache.cs b/src/Serilog/Core/Pipeline/MessageTemplateCache.cs
@@ -51,6 +51,8 @@ public MessageTemplate Parse(string messageTemplate)
                 return _innerParser.Parse(messageTemplate);
 
 #if HASHTABLE
+            // ReSharper disable once InconsistentlySynchronizedField
+            // ignored warning because this is by design
             var result = (MessageTemplate)_templates[messageTemplate];
             if (result != null)
                 return result;