-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy columns #263
Conversation
Deploying datachain-documentation with
|
Latest commit: |
fafe4b5
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2b2468dd.datachain-documentation.pages.dev |
Branch Preview URL: | https://rm-legacy-columns.datachain-documentation.pages.dev |
e61f4bf
to
05a3585
Compare
05a3585
to
7b9121e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 87.07% 87.09% +0.01%
==========================================
Files 92 92
Lines 9952 9925 -27
Branches 2037 2031 -6
==========================================
- Hits 8666 8644 -22
+ Misses 931 927 -4
+ Partials 355 354 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
839b118
to
c6a0471
Compare
c6a0471
to
ed47bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Do we need to invalidate listing on the Studio side or remove them? Does it also invalidate datasets (do they have these file fields inherited from listings)?
ed47bef
to
4c30f90
Compare
@shcheklein This makes existing listing tables invalid, but I think that's irrelevant after #294. For datasets, the only change is that |
@rlamy are we good to go here? :) |
4c30f90
to
d4e50ec
Compare
@shcheklein The datachain part works, but we need the Studio tests to pass... |
bb720ab
to
8d15525
Compare
8d15525
to
36f2d9d
Compare
36f2d9d
to
fafe4b5
Compare
This removes the following attributes or columns from various internal classes and tables:
vtype
,dir_type
,owner_name
,owner_id
. Note thatNode.dir_type
is still used though.The publicly visible, backwards-incompatible changes are:
File.vtype
is removedPart of #36