-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Studio tests in CI #308
Conversation
Deploying datachain-documentation with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 86.85% 86.85%
=======================================
Files 90 90
Lines 9866 9866
Branches 1995 1995
=======================================
Hits 8569 8569
Misses 947 947
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7f22e33
to
7b6a8b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM is that works and gives us what we need in terms of badges!
This should works since badge URL looks like this: We still will be able to see if Studio tests fails in PRs, but this will not affects badge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hm, interesting. Let me check 👍 |
It looks like workflows with duplicate names are not running by GitHub CI. Leave it as "Studio Tests" for now, please, feel free to update it if you'll find a better name or find a way to use same "Tests" name ❤️ |
Split Studio tests into separate workflow. This way we able to see when tests are fails, but "tests" badge in readme will only represent DataChain CLI tests status.