Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Studio tests in CI #308

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Split Studio tests in CI #308

merged 5 commits into from
Aug 17, 2024

Conversation

dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Aug 15, 2024

Split Studio tests into separate workflow. This way we able to see when tests are fails, but "tests" badge in readme will only represent DataChain CLI tests status.

@dreadatour dreadatour self-assigned this Aug 15, 2024
@dreadatour dreadatour marked this pull request as draft August 15, 2024 15:44
Copy link

cloudflare-workers-and-pages bot commented Aug 15, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 336292f
Status: ✅  Deploy successful!
Preview URL: https://d7e49da0.datachain-documentation.pages.dev
Branch Preview URL: https://split-studio-tests-github-ac.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (25e8d3f) to head (336292f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files          90       90           
  Lines        9866     9866           
  Branches     1995     1995           
=======================================
  Hits         8569     8569           
  Misses        947      947           
  Partials      350      350           
Flag Coverage Δ
datachain 86.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreadatour dreadatour force-pushed the split-studio-tests-github-action branch from 7f22e33 to 7b6a8b7 Compare August 15, 2024 16:04
@dreadatour dreadatour requested a review from a team August 15, 2024 16:05
@dreadatour dreadatour marked this pull request as ready for review August 15, 2024 16:05
@dreadatour dreadatour requested a review from a team August 15, 2024 16:06
@dreadatour dreadatour linked an issue Aug 15, 2024 that may be closed by this pull request
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM is that works and gives us what we need in terms of badges!

@dreadatour
Copy link
Contributor Author

LTGM is that works and gives us what we need in terms of badges!

This should works since badge URL looks like this: https://github.com/iterative/datachain/actions/workflows/tests.yml/badge.svg

We still will be able to see if Studio tests fails in PRs, but this will not affects badge.

Copy link
Contributor

@dtulga dtulga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mattseddon
Copy link
Member

[N] Can we keep the action name as Tests / studio?

image

@dreadatour
Copy link
Contributor Author

[N] Can we keep the action name as Tests / studio?

Hm, interesting. Let me check 👍

@dreadatour
Copy link
Contributor Author

[N] Can we keep the action name as Tests / studio?

Hm, interesting. Let me check 👍

It looks like workflows with duplicate names are not running by GitHub CI. Leave it as "Studio Tests" for now, please, feel free to update it if you'll find a better name or find a way to use same "Tests" name ❤️

@dreadatour dreadatour merged commit 9642030 into main Aug 17, 2024
38 checks passed
@dreadatour dreadatour deleted the split-studio-tests-github-action branch August 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing all the time
5 participants