Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nltk pin #332

Merged
merged 1 commit into from
Aug 21, 2024
Merged

remove nltk pin #332

merged 1 commit into from
Aug 21, 2024

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 21, 2024

The most recent version of unstructured has moved to nltk==3.9.1. We want to use that version of unstructured now so we need to remove the pin.

@mattseddon mattseddon self-assigned this Aug 21, 2024
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ce9553
Status: ✅  Deploy successful!
Preview URL: https://0171ff27.datachain-documentation.pages.dev
Branch Preview URL: https://remove-nltk-pin.datachain-documentation.pages.dev

View logs

@mattseddon
Copy link
Member Author

if this works this PR will replace #309

@mattseddon mattseddon marked this pull request as ready for review August 21, 2024 02:09
@mattseddon mattseddon requested a review from a team August 21, 2024 02:09
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (70fe5a1) to head (9ce9553).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files          90       90           
  Lines        9898     9898           
  Branches     1995     1995           
=======================================
  Hits         8606     8606           
  Misses        944      944           
  Partials      348      348           
Flag Coverage Δ
datachain 86.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon merged commit 06fdd8c into main Aug 21, 2024
38 checks passed
@mattseddon mattseddon deleted the remove-nltk-pin branch August 21, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants