Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct fixtures in tests #428

Merged
merged 1 commit into from
Sep 11, 2024
Merged

use the correct fixtures in tests #428

merged 1 commit into from
Sep 11, 2024

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Sep 11, 2024

Here I've switched over from catalog to test_session in a few tests and then from catalog to catalog_tmpfile in some tests that use parallel processing.

Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4dd749
Status: ✅  Deploy successful!
Preview URL: https://740efe6e.datachain-documentation.pages.dev
Branch Preview URL: https://use-correct-fixtures.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (424b05b) to head (b4dd749).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   87.31%   87.32%           
=======================================
  Files          92       92           
  Lines        9982     9986    +4     
  Branches     2041     2041           
=======================================
+ Hits         8716     8720    +4     
  Misses        911      911           
  Partials      355      355           
Flag Coverage Δ
datachain 87.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon self-assigned this Sep 11, 2024
@mattseddon mattseddon marked this pull request as ready for review September 11, 2024 10:13
@mattseddon mattseddon requested a review from a team September 11, 2024 10:13
Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍
Thank you for handling all these issues ❤️

@mattseddon mattseddon merged commit 43f5b21 into main Sep 11, 2024
37 of 38 checks passed
@mattseddon mattseddon deleted the use-correct-fixtures branch September 11, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants