Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more attempt to explore caching images from huggingface datasets. In this approach, each image is saved in a MemoryFileSystem and then cached as a regular image file, which means cache is always on for these objects.
Here is the performance for an example:
Performance during
chain.save()
may be hurt by not having an async implementation for MemoryFileSystem. It may be possible to further optimize how the images are saved to the cache.Here is the same on the main branch for comparison:
Performance looks pretty similar, so it's up to a preference between saving the images in the warehouse db or in the file cache.