Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SQLAlchemy from DataChain.compare() #881

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Feb 1, 2025

Removing SQLAlchemy constructs from compare() function.

TODO:

@ilongin ilongin marked this pull request as draft February 1, 2025 02:53
@ilongin ilongin linked an issue Feb 1, 2025 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Feb 1, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2a3257
Status: ✅  Deploy successful!
Preview URL: https://f21d8c81.datachain-documentation.pages.dev
Branch Preview URL: https://ilongin-721-compare-remove-s.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (b275928) to head (e2a3257).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   87.72%   87.69%   -0.04%     
==========================================
  Files         129      129              
  Lines       11475    11457      -18     
  Branches     1545     1544       -1     
==========================================
- Hits        10067    10047      -20     
- Misses       1020     1021       +1     
- Partials      388      389       +1     
Flag Coverage Δ
datachain 87.61% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilongin ilongin marked this pull request as ready for review February 4, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try removing SQLALchemy code in DataChain.compare() with our own API
1 participant