Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize Ultralytics Yolo models #900

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Feb 6, 2025

Add function to visualize Yolo results.

Bounding boxes conversion will be added in separate PR to do not block video examples PR here.

TODO

@dreadatour dreadatour requested a review from a team February 6, 2025 12:55
@dreadatour dreadatour self-assigned this Feb 6, 2025
@dreadatour dreadatour marked this pull request as draft February 6, 2025 12:55
Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb3758c
Status: ✅  Deploy successful!
Preview URL: https://992b2d13.datachain-documentation.pages.dev
Branch Preview URL: https://ultralytics-yolo.datachain-documentation.pages.dev

View logs

@dreadatour dreadatour mentioned this pull request Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (79f6cf9) to head (cb3758c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/toolkit/ultralytics.py 0.00% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   87.69%   87.27%   -0.42%     
==========================================
  Files         130      131       +1     
  Lines       11664    11720      +56     
  Branches     1586     1597      +11     
==========================================
  Hits        10229    10229              
- Misses       1038     1094      +56     
  Partials      397      397              
Flag Coverage Δ
datachain 87.20% <0.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreadatour dreadatour marked this pull request as ready for review February 7, 2025 02:58
@dreadatour dreadatour changed the title Ultralytics Yolo features Visualize Ultralytics Yolo models Feb 7, 2025
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need some tests for this? I assume this is to make the tutorial simpler?

@dreadatour
Copy link
Contributor Author

we need some tests for this? I assume this is to make the tutorial simpler?

I am not sure how to test this 🤔 Still thinking.
I've updated examples to add ultralytics signals visualization: bboxes, poses and segments. We'll see if it fails since we run examples in CI.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, does this PR still need review?

@dreadatour dreadatour marked this pull request as draft February 26, 2025 08:55
@dreadatour
Copy link
Contributor Author

so, does this PR still need review?

Not yet, I'll be back to this PR after #924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants