Rename export_files to to_storage with cloud support #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
5cfb9b1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d60f6aa5.datachain-documentation.pages.dev |
| Branch Preview URL: | https://amrit-rename-export-files.datachain-documentation.pages.dev |
amritghimire
force-pushed
the
amrit/rename-export-files
branch
2 times, most recently
from
04511f3 to
f918e39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 87.66% 87.67%
=======================================
Files 130 130
Lines 11700 11708 +8
Branches 1592 1592
=======================================
+ Hits 10257 10265 +8
Misses 1043 1043
Partials 400 400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amritghimire
force-pushed
the
amrit/rename-export-files
branch
from
eac7935 to
1c81f79
Compare
dreadatour
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Looks good to me! ❤️
Just wonder if it will be a good idea to add example to the docs?
This renames the export files to to storage adding the support for the
cloud destinations as well.
With this change, the following code will work:
```py
from datachain.lib.dc import DataChain
ds = DataChain.from_storage("az://amrit-test-az/image.png")
ds.save("az")
ds.to_storage("gs://amrit-datachain-test/destination", placement="filename")
```
Closes #859
amritghimire
force-pushed
the
amrit/rename-export-files
branch
from
79efe68 to
415b73e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the export files to to storage adding the support for the
cloud destinations as well.
With this change, the following code will work:
Closes #859