Skip to content

Commit

Permalink
fix: "hkup -v" produces correct version
Browse files Browse the repository at this point in the history
- Updated release-please.yml to take the full package path to the
  version variable

This should fix issue where running "hkup -v" results in version "dev".
  • Loading branch information
iton0 committed Dec 5, 2024
1 parent 308a141 commit 0671c0e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ jobs:
mkdir -p bin
# Build for Linux
GOOS=linux GOARCH=amd64 go build -o bin/hkup-linux -ldflags="-s -w -X cmd.version=${VERSION}" .
GOOS=linux GOARCH=amd64 go build -o bin/hkup-linux -ldflags="-s -w -X github.com/iton0/hkup-cli/cmd.version=${VERSION}" .
# Build for Darwin/macOS
GOOS=darwin GOARCH=amd64 go build -o bin/hkup-darwin -ldflags="-s -w -X cmd.version=${VERSION}" .
GOOS=darwin GOARCH=amd64 go build -o bin/hkup-darwin -ldflags="-s -w -X github.com/iton0/hkup-cli/cmd.version=${VERSION}" .
# Build for Windows
GOOS=windows GOARCH=amd64 go build -o bin/hkup.exe -ldflags="-s -w -X cmd.version=${VERSION}" .
GOOS=windows GOARCH=amd64 go build -o bin/hkup.exe -ldflags="-s -w -X github.com/iton0/hkup-cli/cmd.version=${VERSION}" .
# Step 5: Upload Release Artifacts if a release was created
- name: Upload Release Artifacts
Expand Down

0 comments on commit 0671c0e

Please sign in to comment.