Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 update docs #302

Draft
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Draft

Conversation

mentalko
Copy link

@mentalko mentalko commented Mar 4, 2021

No description provided.

@mentalko
Copy link
Author

mentalko commented Mar 4, 2021

I forgot to delete this sentence " and also no Customer Addresses option in module configuration" from documentation.

@trojikman trojikman requested a review from yelizariev March 4, 2021 11:30
Copy link
Collaborator

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

access_restricted/doc/index.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/doc/index.rst Outdated Show resolved Hide resolved
access_restricted/doc/index.rst Outdated Show resolved Hide resolved
@trojikman trojikman marked this pull request as draft April 13, 2021 10:45
Copy link
Contributor

@trojikman trojikman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо объединить всё в один коммит

@mentalko mentalko force-pushed the 14.0-update_docs branch from 38ad8e3 to 65e2eae Compare May 6, 2021 10:13
@trojikman trojikman requested a review from yelizariev May 6, 2021 10:13
Copy link
Collaborator

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

индекс.рст только начало проверил

access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/README.rst Outdated Show resolved Hide resolved
access_restricted/doc/index.rst Outdated Show resolved Hide resolved
access_restricted/doc/index.rst Outdated Show resolved Hide resolved
@mentalko mentalko force-pushed the 14.0-update_docs branch from 65e2eae to 9df40da Compare May 9, 2021 19:13
Comment on lines +13 to +14
This module adds a special group **'Allow add implied groups from settings'** whose users
can grant other users more access rights by adding them to the same group.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В объяснении не написано при чем тут Settings. Плюс, кавычки можно не ставить если уже есть выделение жирным

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mentalko ты пометил комментарий как resolved, но не докинул исправление - не надо так
download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants