Skip to content

Commit

Permalink
*: simplify pointCollapsingIter, use vanilla iters for foreign SSTs
Browse files Browse the repository at this point in the history
Previously we were using pointCollapsingIters to collapse obsolete
points in foreign sstables. This was necessary because of snapshots
that were open at the time those sstables were written, however they
really blew up code complexity and performance. This change
transitions to using vanilla sstable iterators for foreign sstables
with `hideObsoletePoints` set to true. We error out if the
sstable format for a foreign sstable is not high enough to support
the obsolete flag.

Also remove all cases in the pointCollapsingIter that were not
used by ScanInternal (which is the last remaining user of it).

Part of cockroachdb#2756.
  • Loading branch information
itsbilal committed Jul 28, 2023
1 parent ce43e65 commit 3531d8b
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 488 deletions.
Loading

0 comments on commit 3531d8b

Please sign in to comment.