Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLBA (WIP) #75

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Add MLBA (WIP) #75

merged 6 commits into from
Jul 3, 2024

Conversation

itsdfish
Copy link
Owner

No description provided.

src/MLBA.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 77.58621% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (2dadbf5) to head (1d51f2e).
Report is 12 commits behind head on master.

Files Patch % Lines
src/MLBA.jl 74.50% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   90.27%   89.11%   -1.16%     
==========================================
  Files          24       27       +3     
  Lines        1480     1699     +219     
==========================================
+ Hits         1336     1514     +178     
- Misses        144      185      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Benchmark Results

master f38aef4... master/f38aef4e5e8c57...
logpdf/("SequentialSamplingModels.DDM", 10) 1.69 ± 0.17 μs 1.68 ± 0.18 μs 1
logpdf/("SequentialSamplingModels.DDM", 100) 17.2 ± 0.68 μs 17.3 ± 0.65 μs 0.999
logpdf/("SequentialSamplingModels.LBA", 10) 2.5 ± 0.19 μs 2.51 ± 0.19 μs 0.997
logpdf/("SequentialSamplingModels.LBA", 100) 23.9 ± 0.63 μs 24 ± 0.58 μs 0.997
logpdf/("SequentialSamplingModels.LNR", 10) 1.02 ± 0.18 μs 1.02 ± 0.17 μs 0.997
logpdf/("SequentialSamplingModels.LNR", 100) 8.63 ± 0.28 μs 8.67 ± 0.28 μs 0.995
logpdf/("SequentialSamplingModels.RDM", 10) 2.64 ± 0.25 μs 2.65 ± 0.25 μs 0.997
logpdf/("SequentialSamplingModels.RDM", 100) 25.2 ± 0.7 μs 25.2 ± 0.71 μs 0.999
logpdf/("SequentialSamplingModels.Wald", 10) 0.227 ± 0.17 μs 0.226 ± 0.17 μs 1.01
logpdf/("SequentialSamplingModels.Wald", 100) 2.02 ± 0.05 μs 2.02 ± 0.046 μs 1
logpdf/("SequentialSamplingModels.WaldMixture", 10) 1.12 ± 0.17 μs 1.12 ± 0.17 μs 0.997
logpdf/("SequentialSamplingModels.WaldMixture", 100) 10.9 ± 0.16 μs 10.9 ± 0.18 μs 0.995
rand/("SequentialSamplingModels.DDM", 10) 2.89 ± 0.35 μs 2.91 ± 0.35 μs 0.995
rand/("SequentialSamplingModels.DDM", 100) 27.6 ± 1.3 μs 27.7 ± 1.3 μs 0.998
rand/("SequentialSamplingModels.LBA", 10) 3.25 ± 1.2 μs 3.24 ± 1.3 μs 1
rand/("SequentialSamplingModels.LBA", 100) 16.8 ± 0.4 μs 16.6 ± 0.36 μs 1.01
rand/("SequentialSamplingModels.LCA", 10) 0.601 ± 0.21 ms 0.586 ± 0.21 ms 1.02
rand/("SequentialSamplingModels.LCA", 100) 6.62 ± 0.29 ms 6.46 ± 0.26 ms 1.02
rand/("SequentialSamplingModels.LNR", 10) 1.07 ± 0.17 μs 1.07 ± 0.16 μs 1
rand/("SequentialSamplingModels.LNR", 100) 7.46 ± 3.7 μs 7.45 ± 3.7 μs 1
rand/("SequentialSamplingModels.RDM", 10) 1.58 ± 0.35 μs 1.51 ± 0.34 μs 1.05
rand/("SequentialSamplingModels.RDM", 100) 10.9 ± 3.9 μs 10.9 ± 3.8 μs 1
rand/("SequentialSamplingModels.Wald", 10) 0.465 ± 0.16 μs 0.464 ± 0.16 μs 1
rand/("SequentialSamplingModels.Wald", 100) 2.9 ± 0.2 μs 2.91 ± 0.24 μs 0.996
rand/("SequentialSamplingModels.WaldMixture", 10) 1.23 ± 0.17 μs 1.22 ± 0.16 μs 1
rand/("SequentialSamplingModels.WaldMixture", 100) 11.9 ± 0.2 μs 11.8 ± 0.19 μs 1
simulate/SequentialSamplingModels.DDM 3.8 ± 1.6 μs 3.77 ± 1.4 μs 1.01
simulate/SequentialSamplingModels.LBA 3.7 ± 0.35 μs 2.21 ± 0.074 μs 1.67
simulate/SequentialSamplingModels.LCA 0.0829 ± 0.015 ms 0.0821 ± 0.018 ms 1.01
simulate/SequentialSamplingModels.RDM 0.104 ± 0.035 ms 0.0754 ± 0.023 ms 1.38
simulate/SequentialSamplingModels.Wald 9.39 ± 5.1 μs 9.31 ± 4.8 μs 1.01
simulate/SequentialSamplingModels.WaldMixture 4.04 ± 1.6 μs 4.04 ± 1.5 μs 1
simulate/mdft 0.186 ± 0.072 ms 0.178 ± 0.065 ms 1.04
time_to_load 1.58 ± 0.025 s 1.59 ± 0.02 s 0.998

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@itsdfish itsdfish merged commit aa97497 into master Jul 3, 2024
5 checks passed
@itsdfish itsdfish deleted the mlba branch July 21, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants