Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add p2/index.qmd #21

Merged
merged 2 commits into from
Oct 28, 2024
Merged

add p2/index.qmd #21

merged 2 commits into from
Oct 28, 2024

Conversation

yyuanxuan
Copy link
Collaborator

add p2/index.qmd

add p2/index.qmd
@Robinlovelace
Copy link
Member

Great job @yyuanxuan, looking good!

Can you add spData to the package with:

usethis::use_package("spData")

And any other packages not currently in the DESCRIPTION file?

add required packages (p2)
@yyuanxuan yyuanxuan merged commit 45f404e into main Oct 28, 2024
1 check passed
@yyuanxuan
Copy link
Collaborator Author

Great job @yyuanxuan, looking good!

Can you add spData to the package with:

usethis::use_package("spData")

And any other packages not currently in the DESCRIPTION file?

Thanks for the advice, p2 (link) is now working ok. This gives me much more confidence to continue porting the other practicals and I am happy to do that.

@Robinlovelace Robinlovelace deleted the add-p2 branch October 28, 2024 13:24
@Robinlovelace
Copy link
Member

Great job, good to see tests passing!

Robinlovelace pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants