310-postgres-add-comment-in-change #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror handling - Extend the Column model by adding a new field `isCommentNull` to indicate when a column comment is intended to be null. - Update the JSON schema output in the `toSchema` proc to include the `isCommentNull` flag. - Overload the `comment` proc to handle a nil argument by setting `isCommentNull` to true. - Introduce new PostgreSQL query procs (`addCommentColumn` and `addNullCommentColumn`) to generate appropriate COMMENT queries based on whether a comment is provided or set to null. - Modify add and change column query functions to conditionally include comment queries using `commentContent` and `isCommentNull`. - Enhance schema generation in both PostgreSQL and SQLite by accepting a configurable schema file path (defaulting to the current directory) and adding robust error handling. - Update tests to verify the new behavior for column comments and schema generation.
itsumura-h
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for null column comments and improve schema generation error handling
isCommentNullto indicate when a column comment is intended to be null.toSchemaproc to include theisCommentNullflag.commentproc to handle a nil argument by settingisCommentNullto true.addCommentColumnandaddNullCommentColumn) to generate appropriate COMMENT queries based on whether a comment is provided or set to null.commentContentandisCommentNull.