Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

311-fix-create-schema-test #313

Merged
merged 1 commit into from
Feb 8, 2025
Merged

311-fix-create-schema-test #313

merged 1 commit into from
Feb 8, 2025

Conversation

itsumura-h
Copy link
Owner

Refactor schema generation to allow custom schema file paths and improve error handling

  • Update createSchema procedures for MariaDB, MySQL, and Surreal to accept an optional schemaPath parameter.
  • If no path is provided, use the current directory with "schema.nim" as the default file name.
  • Wrap schema generation logic in try/except blocks to capture and report detailed errors.
  • Update tests to clear tables and pass the explicit schema file path.

…ove error handling

- Update createSchema procedures for MariaDB, MySQL, and Surreal to accept an optional schemaPath parameter.
- If no path is provided, use the current directory with "schema.nim" as the default file name.
- Wrap schema generation logic in try/except blocks to capture and report detailed errors.
- Update tests to clear tables and pass the explicit schema file path.
@itsumura-h itsumura-h linked an issue Feb 8, 2025 that may be closed by this pull request
@itsumura-h itsumura-h merged commit dfde7d9 into main Feb 8, 2025
5 checks passed
@itsumura-h itsumura-h deleted the 311-fix-create-schema-test branch February 8, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix create schema test
1 participant