Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixed to behaviour #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some fixed to behaviour #10

wants to merge 2 commits into from

Conversation

majioa
Copy link

@majioa majioa commented Jun 4, 2019

  • Added nginx_sites_available_subfolder and nginx_sites_enabled_subfoldrr params to make change config subfolder available
  • Fixed upload config to a root owner folder

@majioa
Copy link
Author

majioa commented Jun 17, 2019

@ivalkeen ?

Copy link
Collaborator

@koenpunt koenpunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there default installations of nginx where the folders are suffixed with .d?

config_link = "#{fetch(:nginx_path)}/sites-enabled/#{fetch(:application)}.conf"
execute :unlink, config_link if test "[ -f #{config_link} ]"
config_link = "#{fetch(:nginx_path)}/#{fetch(:nginx_sites_enabled_subfolder)}/#{fetch(:application)}.conf"
sudo :unlink, config_link if test "[ -f #{config_link} ]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't use sudo. Instead you should give the user that commands run as permission to access and modify the necessary files and directories.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there default installations of nginx where the folders are suffixed with .d?

What do you mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants