Skip to content

Commit

Permalink
fix(ci): use JDK 17
Browse files Browse the repository at this point in the history
  • Loading branch information
arkon committed Mar 31, 2024
1 parent 3119bf3 commit 705c033
Show file tree
Hide file tree
Showing 9 changed files with 29 additions and 34 deletions.
29 changes: 12 additions & 17 deletions .github/workflows/android-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,38 +13,33 @@ concurrency:
cancel-in-progress: true

jobs:
check_wrapper:
name: Validate Gradle Wrapper
runs-on: ubuntu-latest

steps:
- name: Clone repo
uses: actions/checkout@v2

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v1

build:
name: Build project
needs: check_wrapper
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v2

- name: Copy CI gradle.properties
run: |
mkdir -p ~/.gradle
cp .github/ci-gradle.properties ~/.gradle/gradle.properties
- name: Set up JDK 11
uses: actions/setup-java@v1
- name: Set up JDK
uses: actions/setup-java@v2
with:
java-version: 11
java-version: 17
distribution: adopt

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3

- name: Build APK
run: bash ./gradlew spotlessCheck assembleRelease --stacktrace
run: ./gradlew spotlessCheck assembleRelease --stacktrace

- name: Sign APK
if: github.repository == 'ivaniskandar/shouko' && github.event_name == 'push'
Expand Down
8 changes: 5 additions & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
id 'com.android.application'
id 'kotlin-android'
Expand Down Expand Up @@ -68,7 +70,7 @@ android {
buildTypes.debug.signingConfig signingConfigs.debug
}

applicationVariants.all { variant ->
applicationVariants.configureEach { variant ->
variant.outputs.each { output ->
output.versionNameOverride "$versionName-$gitCommitHash"
}
Expand All @@ -79,7 +81,7 @@ dependencies {
implementation 'androidx.core:core-ktx:1.12.0'
implementation 'androidx.appcompat:appcompat:1.6.1'
implementation 'androidx.activity:activity-compose:1.8.2'
implementation "androidx.navigation:navigation-compose:2.8.0-alpha04"
implementation "androidx.navigation:navigation-compose:2.8.0-alpha05"
implementation "com.github.topjohnwu.libsu:core:5.0.4"
implementation 'com.squareup.logcat:logcat:0.1'
implementation 'com.google.android.gms:play-services-oss-licenses:17.0.1'
Expand Down Expand Up @@ -131,7 +133,7 @@ protobuf {
}
}

tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
tasks.withType(KotlinCompile).configureEach {
kotlinOptions {
freeCompilerArgs += "-opt-in=kotlin.RequiresOptIn"
freeCompilerArgs += "-opt-in=androidx.compose.material.ExperimentalMaterialApi"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import androidx.compose.foundation.layout.navigationBars
import androidx.compose.foundation.layout.sizeIn
import androidx.compose.material.ModalBottomSheetValue
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.rounded.ArrowBack
import androidx.compose.material.icons.automirrored.rounded.ArrowBack
import androidx.compose.material.icons.rounded.MoreVert
import androidx.compose.material.rememberModalBottomSheetState
import androidx.compose.material3.CenterAlignedTopAppBar
Expand Down Expand Up @@ -54,7 +54,6 @@ import androidx.navigation.compose.rememberNavController
import com.google.accompanist.navigation.material.BottomSheetNavigator
import com.google.accompanist.navigation.material.ModalBottomSheetLayout
import com.google.accompanist.navigation.material.bottomSheet
import com.google.accompanist.navigation.material.rememberBottomSheetNavigator
import com.google.android.gms.oss.licenses.OssLicensesMenuActivity
import kotlinx.coroutines.launch
import logcat.LogPriority
Expand Down Expand Up @@ -128,7 +127,7 @@ class MainActivity : ComponentActivity() {
navigationIcon = if (currentRoute != null && currentRoute != Screen.Home.route) {
{
IconButton(onClick = { navController.popBackStack() }) {
Icon(imageVector = Icons.Rounded.ArrowBack, contentDescription = null)
Icon(imageVector = Icons.AutoMirrored.Rounded.ArrowBack, contentDescription = null)
}
}
} else { {} },
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package xyz.ivaniskandar.shouko.ui.component

import androidx.compose.material3.Divider
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
Expand All @@ -9,7 +9,7 @@ import androidx.compose.ui.Modifier
fun SoftDivider(
modifier: Modifier = Modifier,
) {
Divider(
HorizontalDivider(
modifier = modifier,
color = MaterialTheme.colorScheme.onSurfaceVariant.copy(alpha = 0.12F),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Launch
import androidx.compose.material.icons.automirrored.filled.Launch
import androidx.compose.material.icons.outlined.Info
import androidx.compose.material3.AlertDialog
import androidx.compose.material3.ButtonDefaults
Expand Down Expand Up @@ -359,7 +359,7 @@ fun LinkTargetInfoSheet(
.padding(top = 24.dp, bottom = 8.dp),
) {
Icon(
Icons.Default.Launch,
Icons.AutoMirrored.Filled.Launch,
contentDescription = null,
modifier = Modifier.size(ButtonDefaults.IconSize),
)
Expand Down
8 changes: 4 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext {
kotlin_version = "1.9.22"
compose_bom_version = '2024.03.00-alpha01'
compose_compiler_version = '1.5.10'
kotlin_version = "1.9.23"
compose_bom_version = '2024.03.00-alpha02'
compose_compiler_version = '1.5.11'
protobuf_version = '3.25.3'
}
repositories {
Expand All @@ -12,7 +12,7 @@ buildscript {
maven { url 'https://jitpack.io' }
}
dependencies {
classpath 'com.android.tools.build:gradle:8.3.0'
classpath 'com.android.tools.build:gradle:8.3.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath 'com.google.android.gms:oss-licenses-plugin:0.10.6'
classpath 'com.diffplug.spotless:spotless-plugin-gradle:6.16.0'
Expand Down
2 changes: 0 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,5 @@ org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8
# Android operating system, and which are packaged with your app"s APK
# https://developer.android.com/topic/libraries/support-library/androidx-rn
android.useAndroidX=true
# Automatically convert third-party libraries to use AndroidX
android.enableJetifier=true
# Kotlin code style for this project: "official" or "obsolete":
kotlin.code.style=official
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Tue Mar 07 12:57:38 ICT 2023
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
1 change: 1 addition & 0 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ dependencyResolutionManagement {
maven { url 'https://jitpack.io' }
}
}

rootProject.name = "XPERI+"
include ':app'

0 comments on commit 705c033

Please sign in to comment.