Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs for TikZ images #40

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Adding docs for TikZ images #40

merged 1 commit into from
Dec 18, 2024

Conversation

msdemlei
Copy link
Collaborator

This goes together with ivoatex PR 132.

@msdemlei msdemlei force-pushed the document-tikz-graphics branch from 54e2522 to b4127ef Compare November 13, 2024 16:51
mbtaylor
mbtaylor previously approved these changes Dec 18, 2024
Copy link
Member

@mbtaylor mbtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I haven't tried this out and I'm not familiar with tikz, but it looks reasonable.
I made a couple of micro-comments you can look at.


# List of PDF figures (for vector graphics)
VECTORFIGURES =
VECTORFIGURES = hello.tikz.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment here say "List of PDF/SVG figures"?

ivoatexDoc.tex Outdated
include that name in the \verb|VECTORFIGURES| Makefile variable.

IvoatexDoc has an example TikZ image called \verb|hello.tikz.tex|
contaning this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contaning -> containing

@msdemlei msdemlei force-pushed the document-tikz-graphics branch from 0d90a08 to f74a00e Compare December 18, 2024 11:49
@msdemlei msdemlei merged commit ec8d592 into main Dec 18, 2024
@msdemlei msdemlei deleted the document-tikz-graphics branch December 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants