[fix] MacOS build.sh failing on 15.2 Beta (24C5089c) #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
What kind of change does this PR introduce?
PR checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Currently, when running the build.sh for macOS it fails to curl OpenSSL, the patch applied for OSX lion breaks the build for OpenVPN, the OpenSSL being used defaults to system and not what was built by the script, Golang 1.23 is not supported, and passing macOS-version-min=10.6 causes build issues.
Issue number: N/A
What is the new behavior?
Same build workflow, the only changes are flags and updated docs for the correct Golang version. Also, I had enabled lz4 for the OpenVPN build, and it works on M4, I do not have an M1 chip to test.
Does this PR introduce a breaking change?
I had to disable the patching for OSX lion for OpenVPN, so I am pretty sure it will break the build for that specific macOS.
Other information