Skip to content

Network Protection does not work with Custom DNS on iOS 16 and 17 #920

Network Protection does not work with Custom DNS on iOS 16 and 17

Network Protection does not work with Custom DNS on iOS 16 and 17 #920

Triggered via pull request October 18, 2023 10:46
Status Success
Total duration 43s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

swiftlint.yml

on: pull_request
SwiftLint
32s
SwiftLint
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
SwiftLint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
SwiftLint: IVPNWidget/IVPNWidget.swift#L83
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
SwiftLint: IVPNWidget/IVPNWidget.swift#L73
Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
SwiftLint: IVPNWidget/IVPNWidget.swift#L33
Void Return Violation: Prefer `-> Void` over `-> ()`. (void_return)
SwiftLint: IVPNWidget/IVPNWidget.swift#L38
Void Return Violation: Prefer `-> Void` over `-> ()`. (void_return)
SwiftLint: IVPNWidget/IVPNWidget.swift#L42
Void Return Violation: Prefer `-> Void` over `-> ()`. (void_return)
SwiftLint: IVPNClient/Scenes/ViewControllers/ProtocolViewController.swift#L246
Cyclomatic Complexity Violation: Function should have complexity 15 or less: currently complexity equals 35 (cyclomatic_complexity)
SwiftLint: IVPNClient/Scenes/ViewControllers/NetworkProtectionViewController.swift#L220
Unused Closure Parameter Violation: Unused parameter "contextualAction" in a closure should be replaced with _. (unused_closure_parameter)
SwiftLint: IVPNClient/Scenes/ViewControllers/NetworkProtectionViewController.swift#L220
Unused Closure Parameter Violation: Unused parameter "view" in a closure should be replaced with _. (unused_closure_parameter)
SwiftLint: IVPNClient/Scenes/ViewControllers/NetworkProtectionViewController.swift#L220
Unused Closure Parameter Violation: Unused parameter "boolValue" in a closure should be replaced with _. (unused_closure_parameter)
SwiftLint: IVPNClient/Scenes/ViewControllers/MTUViewController.swift#L103
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)