Skip to content

Network Protection does not work with Custom DNS on iOS 16 and 17 #921

Network Protection does not work with Custom DNS on iOS 16 and 17

Network Protection does not work with Custom DNS on iOS 16 and 17 #921

Triggered via pull request October 19, 2023 07:56
Status Success
Total duration 46s
Artifacts

swiftlint.yml

on: pull_request
SwiftLint
34s
SwiftLint
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
SwiftLint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
SwiftLint: IVPNClient/Scenes/ViewControllers/NetworkProtectionViewController.swift#L220
Unused Closure Parameter Violation: Unused parameter "contextualAction" in a closure should be replaced with _. (unused_closure_parameter)
SwiftLint: IVPNClient/Scenes/ViewControllers/NetworkProtectionViewController.swift#L220
Unused Closure Parameter Violation: Unused parameter "view" in a closure should be replaced with _. (unused_closure_parameter)
SwiftLint: IVPNClient/Scenes/ViewControllers/NetworkProtectionViewController.swift#L220
Unused Closure Parameter Violation: Unused parameter "boolValue" in a closure should be replaced with _. (unused_closure_parameter)
SwiftLint: IVPNClient/Scenes/ViewControllers/MTUViewController.swift#L103
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
SwiftLint: IVPNClient/Scenes/ViewControllers/ProtocolViewController.swift#L246
Cyclomatic Complexity Violation: Function should have complexity 15 or less: currently complexity equals 35 (cyclomatic_complexity)
SwiftLint: IVPNClient/Models/VPNServerList.swift#L93
Cyclomatic Complexity Violation: Function should have complexity 15 or less: currently complexity equals 29 (cyclomatic_complexity)
SwiftLint: IVPNClient/AppDelegate.swift#L349
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
SwiftLint: IVPNClient/Managers/APIClient.swift#L123
Cyclomatic Complexity Violation: Function should have complexity 15 or less: currently complexity equals 18 (cyclomatic_complexity)
SwiftLint: IVPNClient/Utilities/Kem/KemHelper.swift#L28
Redundant String Enum Value Violation: String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)
SwiftLint: IVPNWidget/IVPNWidget.swift#L83
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)