Fix: Handle Craft Links with Custom Domains by Implementing getCraftSlug Function #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@memoli0 is attempting to deploy a commit to the zuolan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@izuolan , can you check it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Craft application used for displaying notes has introduced a feature allowing users to share links with custom domains. Previously, links followed the pattern "https://www.craft.do/s/" with a 23-character slug, which was sliced to extract the necessary ID. However, this approach fails with the new custom domain links, causing issues in preview images and other functionalities. This affects new users configuring the Craft settings for the project as well.
To address this problem, I have implemented a
getCraftSlugfunction in thelibdirectory. This function correctly extracts the slug from both the old and new link formats, ensuring the application functions correctly without errors. This change ensures that both legacy and new links are handled seamlessly, maintaining the integrity of the application for all users.