Exposed BaseDatabaseType's int, float and double type string appenders to protected #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks much. |
|
I have a feeling this may bite us in the butt later on... Are we sure these strings are the same across all supported databases? |
|
Well it's SQL standard. But even if they were different then it was impossible to override before and now it is possible. I'm not quite sure what the issue is you're describing. |
|
Okay, I must have woken up on the wrong side :) I actually read it backwards -- that the implementation was protected and now it's private. My bad! Very good change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not too much reason for these to be the only ones that are private. While the need to override these methods will not be common, it does allow for the likes of example 1 in #20 (comment) to be possible.