-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom attachments #20
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b6b4a21
Add mutable string accessor macro.
brandon-reinhart f639f86
Add an attachment loader wrapper.
brandon-reinhart 97023c0
temp patch spine_c to refcount
brandon-reinhart 95e71b2
Convenience fn for creating region attachments.
brandon-reinhart 2f9e7e3
return nulerror
brandon-reinhart a9030b9
clippy
brandon-reinhart 652707c
fix doc string refs
brandon-reinhart 1260f39
move unsafe to interior
brandon-reinhart bf73a7e
undo
brandon-reinhart e652845
mark unsafe again
brandon-reinhart ea5fc8c
clippy
brandon-reinhart 3bba71c
Update src/attachment_loader.rs
jabuwu f44e927
Update slot.rs
jabuwu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add mutable string accessor macro.
- Loading branch information
commit b6b4a21ec8b1823b1d2be99c17a58ee5f8c40028
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize it's an exceedingly rare case, but I think we should bubble up the error here, wrapped in
SpineError::NulError
.