fix(api): fix issue loading Azure OpenAI configuration #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of asynchronous operations, loading *_cmd options from configuration was not working properly. It was only working using the environment variables. Also add a missing options to set API type (api_type_cmd) from vim config files instead of having to set a environment variable.
- Format README.md file to comply with regular MD guidelines (linter findings) - Add information about new configuration options to configure Azure deployment programmatically.
|
Rebase and fix linter findings. |
jackMort
approved these changes
Feb 25, 2024
|
@jackMort, a new commit solving the style finding in the CI. |
Wezea
pushed a commit
to Wezea/ChatGPT.nvim
that referenced
this pull request
Apr 20, 2024
* fix(api): fix issue loading Azure OpenAI configuration Because of asynchronous operations, loading *_cmd options from configuration was not working properly. It was only working using the environment variables. Also add a missing options to set API type (api_type_cmd) from vim config files instead of having to set a environment variable. * style: fix linter findings and update README documentation - Format README.md file to comply with regular MD guidelines (linter findings) - Add information about new configuration options to configure Azure deployment programmatically. * style(api): fix stylua style findings --------- Co-authored-by: Alejandro Claro <[email protected]>
qaptoR
pushed a commit
to qaptoR-nvim/ChatGPT.nvim
that referenced
this pull request
Jul 6, 2024
* fix(api): fix issue loading Azure OpenAI configuration Because of asynchronous operations, loading *_cmd options from configuration was not working properly. It was only working using the environment variables. Also add a missing options to set API type (api_type_cmd) from vim config files instead of having to set a environment variable. * style: fix linter findings and update README documentation - Format README.md file to comply with regular MD guidelines (linter findings) - Add information about new configuration options to configure Azure deployment programmatically. * style(api): fix stylua style findings --------- Co-authored-by: Alejandro Claro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to asynchronous operations, loading the *_cmd options for Azure from the vim configuration was not working correctly. It only worked using the environment variables.
This also adds a missing option to set the API type (api_type_cmd) from the vim configuration files instead of having to set an environment variable.
Fixes #365