Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Allow caching for output ports #602

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

API: Allow caching for output ports #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/jack/jack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,15 +760,15 @@ int jack_port_unregister (jack_client_t *client, jack_port_t *port) JACK_OPTIONA
* zero-filled. if there are multiple inbound connections, the data
* will be mixed appropriately.
*
* FOR OUTPUT PORTS ONLY : DEPRECATED in Jack 2.0 !!
* ---------------------------------------------------
* FOR OUTPUT PORTS ONLY
* ---------------------
* You may cache the value returned, but only between calls to
* your "blocksize" callback. For this reason alone, you should
* either never cache the return value or ensure you have
* a "blocksize" callback and be sure to invalidate the cached
* address from there.
*
* Caching output ports is DEPRECATED in Jack 2.0, due to some new optimization (like "pipelining").
* Caching input ports is not allowed, due to some new optimization (like "pipelining").
* Port buffers have to be retrieved in each callback for proper functioning.
*/
void * jack_port_get_buffer (jack_port_t *port, jack_nframes_t) JACK_OPTIONAL_WEAK_EXPORT;
Expand Down
7 changes: 4 additions & 3 deletions common/jack/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,13 +468,14 @@ enum JackPortFlags {

/**
* if JackPortIsInput is set, then the port can receive
* data.
* data from output ports. The creator of this port can
* read from it.
*/
JackPortIsInput = 0x1,

/**
* if JackPortIsOutput is set, then data can be read from
* the port.
* if JackPortIsOutput is set, then data can be forwarded to
* input ports. The creator of this port can write to it.
*/
JackPortIsOutput = 0x2,

Expand Down